Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce genericapiserver api surface #33266

Merged
merged 1 commit into from Sep 23, 2016
Merged

Reduce genericapiserver api surface #33266

merged 1 commit into from Sep 23, 2016

Conversation

sttts
Copy link
Contributor

@sttts sttts commented Sep 22, 2016 •
edited by k8s-oncall

This change is Reviewable

@sttts sttts added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/apiserver labels Sep 22, 2016
@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-label-needed labels Sep 22, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins GCE e2e failed for commit 5d4479b.

The magic incantation to run this job again is @k8s-bot gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

deads2k
deads2k reviewed Sep 22, 2016
View reviewed changes
pkg/genericapiserver/genericapiserver.go
// Exposes the given group version in API.
func (s *GenericAPIServer) InstallAPIGroup(apiGroupInfo *APIGroupInfo) error {
// Exposes the given api groups in the API.
func (s *GenericAPIServer) InstallAPIGroups(groupsInfo ...[]APIGroupInfo) error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A list of slices? That seems weird. Why?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird, indeed. fixed.

@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 22, 2016
@sttts
Copy link
Contributor Author

sttts commented Sep 22, 2016

@deads2k ptal

@deads2k deads2k added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Sep 22, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 1063903 into kubernetes:master Sep 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k deads2k left review comments

Assignees

@deads2k deads2k

Labels
area/apiserver kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sttts @k8s-ci-robot @k8s-github-robot @deads2k @googlebot